Skip to content

Commit

Permalink
[BUGFIX] D3.js uses basic authentication credentials cached in browser
Browse files Browse the repository at this point in the history
Chrome 64 changed the behaviour regarding xhr.open() calls when passing
null values as password and username.
The d3.js file is manually patched.
Once PR https://github.com/d3/d3-request/pull/34/files is merged we can
use official d3.js version again.

Resolves: #83741
Releases: master, 8.7
Change-Id: I9b83d953ecd19afb9fa5039e1782d094111b0125
Reviewed-on: https://review.typo3.org/55534
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
  • Loading branch information
tmotyl authored and bmack committed Feb 3, 2018
1 parent 559a2a2 commit d59072a
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 2 deletions.
7 changes: 6 additions & 1 deletion Build/Gruntfile.js
Expand Up @@ -432,7 +432,12 @@ module.exports = function (grunt) {
/* disabled until autocomplete formatGroup is fixed to pass on the index too
'jquery.autocomplete.js': '../node_modules/devbridge-autocomplete/dist/jquery.autocomplete.min.js',
*/
'd3/d3.js': 'd3/build/d3.min.js',
/**
* d3/d3.js requires a patch https://github.com/d3/d3-request/pull/34/files
* to solve issue with basic auth in Chrome 64, see https://forge.typo3.org/issues/83741
* for now the file is manually patched by us, thus can't be automatically updated
*/
// 'd3/d3.js': 'd3/build/d3.min.js',
/**
* copy needed parts of jquery
*/
Expand Down

Large diffs are not rendered by default.

0 comments on commit d59072a

Please sign in to comment.