Skip to content

Commit

Permalink
[BUGFIX] Fix typos in TCA migration messages
Browse files Browse the repository at this point in the history 
Improve typos and grammar in messages of the TCA migration

Resolves: #84742
Releases: master, 8.7
Change-Id: I5dca04efcd9bfe796907612500735b4d93dddc41
Reviewed-on: https://review.typo3.org/56678
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
  • Loading branch information
@georgringer @andreaskienast
georgringer authored and andreaskienast committed Apr 16, 2018
1 parent b4b7f81 commit dae14b0
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
12 changes: 6 additions & 6 deletions typo3/sysext/core/Classes/Migrations/TcaMigration.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -724,10 +724,10 @@ protected function migrateElementBrowserWizardToLinkHandler(array $tca): array
if (empty($fieldConfig['config']['wizards']['link']['module']['urlParameters'])) {
unset($fieldConfig['config']['wizards']['link']['module']['urlParameters']);
}
$this->messages[] = 'Reference to "wizard_element_browser" was migrated from"'
$this->messages[] = 'Reference to "wizard_element_browser" was migrated from "'
. $table . '[\'columns\'][\'' . $fieldName . '\'][\'config\'][\'wizards\'][\'link\'][\'module\'][\'name\'] === \'wizard_element_browser\'"'
. 'to new "wizard_link", "'
. $table . '[\'columns\'][\'' . $fieldName . '\'][\'config\'][\'wizards\'][\'link\'][\'module\'][\'name\'] = \'wizard_link\' "';
. ' to new "wizard_link", "'
. $table . '[\'columns\'][\'' . $fieldName . '\'][\'config\'][\'wizards\'][\'link\'][\'module\'][\'name\'] = \'wizard_link\'"';
}
}
}
Expand Down Expand Up @@ -2439,7 +2439,7 @@ protected function migrateInlineOverrideChildTca(array $tca): array
if (isset($fieldConfig['config']['foreign_types']) && is_array($fieldConfig['config']['foreign_types'])) {
$fieldConfig['config']['overrideChildTca']['types'] = $fieldConfig['config']['foreign_types'];
unset($fieldConfig['config']['foreign_types']);
$this->messages[] = 'The \'foreign_types\' property from TCA ' . $table . '[\'types\'][\'' . $typeName . '\'][\'columnOverrides\'][\'' . $fieldName . '\'][\'config\'] and has been migrated to ' . $table . '[\'types\'][\'' . $typeName . '\'][\'columnOverrides\'][\'' . $fieldName . '\'][\'config\'][\'overrideChildTca\'][\'types\']';
$this->messages[] = 'The \'foreign_types\' property from TCA ' . $table . '[\'types\'][\'' . $typeName . '\'][\'columnsOverrides\'][\'' . $fieldName . '\'][\'config\'] has been migrated to ' . $table . '[\'types\'][\'' . $typeName . '\'][\'columnsOverrides\'][\'' . $fieldName . '\'][\'config\'][\'overrideChildTca\'][\'types\']';
}
if (isset($fieldConfig['config']['foreign_selector_fieldTcaOverride']) && is_array($fieldConfig['config']['foreign_selector_fieldTcaOverride'])) {
$foreignSelectorFieldName = '';
Expand All @@ -2451,13 +2451,13 @@ protected function migrateInlineOverrideChildTca(array $tca): array
if ($foreignSelectorFieldName) {
$fieldConfig['config']['overrideChildTca']['columns'][$foreignSelectorFieldName] = $fieldConfig['config']['foreign_selector_fieldTcaOverride'];
unset($fieldConfig['config']['foreign_selector_fieldTcaOverride']);
$this->messages[] = 'The \'foreign_selector_fieldTcaOverride\' property from TCA ' . $table . '[\'types\'][\'' . $typeName . '\'][\'columnOverrides\'][\'' . $fieldName . '\'][\'config\'] and has been migrated to ' . $table . '[\'types\'][\'' . $typeName . '\'][\'columnOverrides\'][\'' . $fieldName . '\'][\'config\'][\'overrideChildTca\'][\'columns\'][\'' . $foreignSelectorFieldName . '\']';
$this->messages[] = 'The \'foreign_selector_fieldTcaOverride\' property from TCA ' . $table . '[\'types\'][\'' . $typeName . '\'][\'columnsOverrides\'][\'' . $fieldName . '\'][\'config\'] and has been migrated to ' . $table . '[\'types\'][\'' . $typeName . '\'][\'columnsOverrides\'][\'' . $fieldName . '\'][\'config\'][\'overrideChildTca\'][\'columns\'][\'' . $foreignSelectorFieldName . '\']';
}
}
if (isset($fieldConfig['config']['foreign_record_defaults']) && is_array($fieldConfig['config']['foreign_record_defaults'])) {
foreach ($fieldConfig['config']['foreign_record_defaults'] as $childFieldName => $defaultValue) {
$fieldConfig['config']['overrideChildTca']['columns'][$childFieldName]['config']['default'] = $defaultValue;
$this->messages[] = 'The \'foreign_record_defaults\' property from TCA ' . $table . '[\'types\'][\'' . $typeName . '\'][\'columnOverrides\'][\'' . $fieldName . '\'][\'config\'][\'' . $childFieldName . '\'] and has been migrated to ' . $table . '[\'types\'][\'' . $typeName . '\'][\'columnOverrides\'][\'' . $fieldName . '\'][\'config\'][\'overrideChildTca\'][\'columns\'][\'' . $childFieldName . '\'][\'config\'][\'default\']';
$this->messages[] = 'The \'foreign_record_defaults\' property from TCA ' . $table . '[\'types\'][\'' . $typeName . '\'][\'columnsOverrides\'][\'' . $fieldName . '\'][\'config\'][\'' . $childFieldName . '\'] and has been migrated to ' . $table . '[\'types\'][\'' . $typeName . '\'][\'columnsOverrides\'][\'' . $fieldName . '\'][\'config\'][\'overrideChildTca\'][\'columns\'][\'' . $childFieldName . '\'][\'config\'][\'default\']';
}
unset($fieldConfig['config']['foreign_record_defaults']);
}
Expand Down
2 changes: 1 addition & 1 deletion .../8.6/Feature-75880-ImplementMultipleCroppingVariantsInImageManipulationTool.rst
View file
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ Please note, that you need to specify the target column name as array key. Most
as this is the default field name for image manipulation in `sys_file_reference`

It is also possible to set the cropping configuration only for a specific tt_content element type by using the
`columnOverrides` feature:
`columnsOverrides` feature:

.. code-block:: php
Expand Down

0 comments on commit dae14b0

Please sign in to comment.