-
Notifications
You must be signed in to change notification settings - Fork 653
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[!!!][TASK] Remove view related properties from ActionController
Both properties $namespacesViewObjectNamePattern and $viewFormatToObjectNameMap of class ActionController have been removed without replacement. Both properties provided a functionality to set a custom view object class during runtime. As this contradicts the idea of having a defined state per request by configuring concrete implementations before runtime, these properties needed to vanish. While there is no dependency injection with a proper configuration available, the view object class can still be defined via property $defaultViewObjectName. Releases: master Resolves: #87511 Change-Id: I4b89a9434f71a3cbf38a9ad113ba8233e7f327f9 Reviewed-on: https://review.typo3.org/59514 Tested-by: TYPO3com <noreply@typo3.com> Reviewed-by: Georg Ringer <georg.ringer@gmail.com> Tested-by: Georg Ringer <georg.ringer@gmail.com> Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by: Achim Fritz <af@achimfritz.de> Reviewed-by: Benni Mack <benni@typo3.org> Tested-by: Benni Mack <benni@typo3.org>
- Loading branch information
1 parent
6c58192
commit e4e01dd
Showing
6 changed files
with
91 additions
and
128 deletions.
There are no files selected for viewing
35 changes: 35 additions & 0 deletions
35
...angelog/master/Breaking-87511-RemoveNamespacesViewObjectNamePatternProperty.rst
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
.. include:: ../../Includes.txt | ||
|
||
=================================================================== | ||
Breaking: #87511 - Remove $namespacesViewObjectNamePattern property | ||
=================================================================== | ||
|
||
See :issue:`87511` | ||
|
||
Description | ||
=========== | ||
|
||
Property :php:`$namespacesViewObjectNamePattern` of class | ||
:php:`\TYPO3\CMS\Extbase\Mvc\Controller\ActionController` has been | ||
removed without replacement. | ||
|
||
Impact | ||
====== | ||
|
||
Overriding the property :php:`$namespacesViewObjectNamePattern` in | ||
controllers that extend :php`ActionController` will no longer trigger | ||
the instantiation of another view object, derived from the pattern. | ||
|
||
Affected Installations | ||
====================== | ||
|
||
All extensions that override the property :php:`$namespacesViewObjectNamePattern`. | ||
|
||
Migration | ||
========= | ||
|
||
If an action needs another template object other than the default | ||
:php:`\TYPO3\CMS\Fluid\View\TemplateView`, the property :php:`$defaultViewObjectName` | ||
needs to be overridden instead. | ||
|
||
.. index:: PHP-API, FullyScanned, ext:extbase |
35 changes: 35 additions & 0 deletions
35
...ion/Changelog/master/Breaking-87511-RemoveViewFormatToObjectNameMapProperty.rst
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
.. include:: ../../Includes.txt | ||
|
||
============================================================= | ||
Breaking: #87511 - Remove $viewFormatToObjectNameMap property | ||
============================================================= | ||
|
||
See :issue:`87511` | ||
|
||
Description | ||
=========== | ||
|
||
Property :php:`$viewFormatToObjectNameMap` of class | ||
:php:`\TYPO3\CMS\Extbase\Mvc\Controller\ActionController` has been | ||
removed without replacement. | ||
|
||
Impact | ||
====== | ||
|
||
Overriding the property :php:`$viewFormatToObjectNameMap` in | ||
controllers that extend :php`ActionController` will no longer trigger | ||
the instantiation of another view object, derived from the mapping. | ||
|
||
Affected Installations | ||
====================== | ||
|
||
All extensions that override the property :php:`$viewFormatToObjectNameMap`. | ||
|
||
Migration | ||
========= | ||
|
||
If an action needs another template object other than the default | ||
:php:`\TYPO3\CMS\Fluid\View\TemplateView`, the property :php:`$defaultViewObjectName` | ||
needs to be overridden instead. | ||
|
||
.. index:: PHP-API, FullyScanned, ext:extbase |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters