Skip to content

Commit

Permalink
[TASK] Make frontend/Tests/Unit/DataProcessing notice free
Browse files Browse the repository at this point in the history
Resolves: #85847
Releases: master
Change-Id: I2fee7a27c3cc5a06f6ef3298ddb1b75b766b2db7
Reviewed-on: https://review.typo3.org/57897
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
  • Loading branch information
lolli42 authored and andreaskienast committed Aug 14, 2018
1 parent abd7594 commit f5641c8
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -494,10 +494,10 @@ protected function prepareGalleryData()
$fileKey = (($row - 1) * $this->galleryData['count']['columns']) + $column - 1;

$this->galleryData['rows'][$row]['columns'][$column] = [
'media' => $this->fileObjects[$fileKey],
'media' => $this->fileObjects[$fileKey] ?? null,
'dimensions' => [
'width' => $this->mediaDimensions[$fileKey]['width'],
'height' => $this->mediaDimensions[$fileKey]['height']
'width' => $this->mediaDimensions[$fileKey]['width'] ?? null,
'height' => $this->mediaDimensions[$fileKey]['height'] ?? null
]
];
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<?php
declare(strict_types = 1);
namespace TYPO3\CMS\Frontend\Tests\Unit\Processor;

/*
Expand All @@ -17,17 +18,13 @@
use TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer;
use TYPO3\CMS\Frontend\ContentObject\Exception\ContentRenderingException;
use TYPO3\CMS\Frontend\DataProcessing\GalleryProcessor;
use TYPO3\TestingFramework\Core\Unit\UnitTestCase;

/**
* Tests for GalleryProcessor
*/
class GalleryProcessorTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
class GalleryProcessorTest extends UnitTestCase
{
/**
* Subject is not notice free, disable E_NOTICES
*/
protected static $suppressNotices = true;

/**
* @var ContentObjectRenderer|\PHPUnit_Framework_MockObject_MockObject
*/
Expand Down

0 comments on commit f5641c8

Please sign in to comment.