Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not using short titles #174

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pjtsearch
Copy link

This PR is to address issue #173, which was that hayagriva did not use the BibTex shorttitle field for short titles in CSL. In order to fix this issue, I made two changes:

  1. In interop.rs, I added functionality for detecting if the BibTex shorttitle exists and adding it to the FormatString if it does.
  2. In taxonomy.rs, I fixed the code for StandardVariable::Title and StandardVariable::TitleShort being switched around. Previously, hayagriva would always select the short title for StandardVariable::Title, but would choose between the short title and long title for StandardVariable::TitleShort, which is obviously incorrect behavior. It appears that the behavior for StandardVariable::TitleShort was mistakenly placed in StandardVariable::Title. I fixed this issue by simply switching the code around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant