Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradient Part 1 - Color rework #2171

Merged
merged 30 commits into from
Sep 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
e3cf88b
Working colors
Dherse Sep 17, 2023
82486ce
Fixed precision
Dherse Sep 17, 2023
4488858
fmt, clippy
Dherse Sep 17, 2023
16bb649
cargo fmt
Dherse Sep 17, 2023
61f532a
Fixed test precision
Dherse Sep 17, 2023
b2ec52e
Fixed issue in color encoding for PDF
Dherse Sep 17, 2023
11d68d9
cargo fmt
Dherse Sep 17, 2023
5f55891
Cleanup of PDF color conversion
Dherse Sep 17, 2023
2d26939
Fixed oklab, HSV and HSL fallbacks
Dherse Sep 17, 2023
d28fd3f
Removed debug println
Dherse Sep 17, 2023
8cf706a
Fixed HSL & HSV ordering
Dherse Sep 17, 2023
e42f317
Avoid division by zero
Dherse Sep 17, 2023
fa07b98
Added dedicated SVG color encoding
Dherse Sep 17, 2023
45b11be
Removed `as-` methods, replaced with `components`
Dherse Sep 17, 2023
cf98af9
Added comments
Dherse Sep 17, 2023
f87ca9d
Replaced STD dependency with libm for WASM compat
Dherse Sep 17, 2023
b396cda
Fixed spelling in comment
Dherse Sep 18, 2023
fe6d08b
Added `saturate` and `desaturate`
Dherse Sep 18, 2023
9d96840
Moved color conversion methods to constructors
Dherse Sep 18, 2023
0c8dd99
Update crates/typst/Cargo.toml
Dherse Sep 18, 2023
113a17b
Fixed most code review items
Dherse Sep 18, 2023
f8b2e4a
Fixed all outstanding issues
Dherse Sep 18, 2023
6670f53
cargo fmt & clippy
Dherse Sep 18, 2023
72646a3
finished clippy
Dherse Sep 18, 2023
c54376b
Fixed ICC d65 bug
Dherse Sep 18, 2023
b1c9b13
Fixed code review items
Dherse Sep 19, 2023
0829deb
Replaced with unscanny
Dherse Sep 19, 2023
dcdf972
Cleanup `color.rs`
Dherse Sep 19, 2023
e223f07
Fixed hsv/hsl repr
Dherse Sep 19, 2023
1cf7102
Tidy up a bit
laurmaedje Sep 19, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
49 changes: 39 additions & 10 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

121 changes: 121 additions & 0 deletions NOTICE
Original file line number Diff line number Diff line change
@@ -1,5 +1,126 @@
Licenses for third party components used by this project can be found below.

================================================================================
The Creative Commons Zero v1.0 Universal License applies to:
* The ICC profiles found in `crates/typst/icc/*`

CC0 1.0 Universal

Statement of Purpose

The laws of most jurisdictions throughout the world automatically confer
exclusive Copyright and Related Rights (defined below) upon the creator and
subsequent owner(s) (each and all, an "owner") of an original work of
authorship and/or a database (each, a "Work").

Certain owners wish to permanently relinquish those rights to a Work for the
purpose of contributing to a commons of creative, cultural and scientific
works ("Commons") that the public can reliably and without fear of later
claims of infringement build upon, modify, incorporate in other works, reuse
and redistribute as freely as possible in any form whatsoever and for any
purposes, including without limitation commercial purposes. These owners may
contribute to the Commons to promote the ideal of a free culture and the
further production of creative, cultural and scientific works, or to gain
reputation or greater distribution for their Work in part through the use and
efforts of others.

For these and/or other purposes and motivations, and without any expectation
of additional consideration or compensation, the person associating CC0 with a
Work (the "Affirmer"), to the extent that he or she is an owner of Copyright
and Related Rights in the Work, voluntarily elects to apply CC0 to the Work
and publicly distribute the Work under its terms, with knowledge of his or her
Copyright and Related Rights in the Work and the meaning and intended legal
effect of CC0 on those rights.

1. Copyright and Related Rights. A Work made available under CC0 may be
protected by copyright and related or neighboring rights ("Copyright and
Related Rights"). Copyright and Related Rights include, but are not limited
to, the following:

i. the right to reproduce, adapt, distribute, perform, display, communicate,
and translate a Work;

ii. moral rights retained by the original author(s) and/or performer(s);

iii. publicity and privacy rights pertaining to a person's image or likeness
depicted in a Work;

iv. rights protecting against unfair competition in regards to a Work,
subject to the limitations in paragraph 4(a), below;

v. rights protecting the extraction, dissemination, use and reuse of data in
a Work;

vi. database rights (such as those arising under Directive 96/9/EC of the
European Parliament and of the Council of 11 March 1996 on the legal
protection of databases, and under any national implementation thereof,
including any amended or successor version of such directive); and

vii. other similar, equivalent or corresponding rights throughout the world
based on applicable law or treaty, and any national implementations thereof.

2. Waiver. To the greatest extent permitted by, but not in contravention of,
applicable law, Affirmer hereby overtly, fully, permanently, irrevocably and
unconditionally waives, abandons, and surrenders all of Affirmer's Copyright
and Related Rights and associated claims and causes of action, whether now
known or unknown (including existing as well as future claims and causes of
action), in the Work (i) in all territories worldwide, (ii) for the maximum
duration provided by applicable law or treaty (including future time
extensions), (iii) in any current or future medium and for any number of
copies, and (iv) for any purpose whatsoever, including without limitation
commercial, advertising or promotional purposes (the "Waiver"). Affirmer makes
the Waiver for the benefit of each member of the public at large and to the
detriment of Affirmer's heirs and successors, fully intending that such Waiver
shall not be subject to revocation, rescission, cancellation, termination, or
any other legal or equitable action to disrupt the quiet enjoyment of the Work
by the public as contemplated by Affirmer's express Statement of Purpose.

3. Public License Fallback. Should any part of the Waiver for any reason be
judged legally invalid or ineffective under applicable law, then the Waiver
shall be preserved to the maximum extent permitted taking into account
Affirmer's express Statement of Purpose. In addition, to the extent the Waiver
is so judged Affirmer hereby grants to each affected person a royalty-free,
non transferable, non sublicensable, non exclusive, irrevocable and
unconditional license to exercise Affirmer's Copyright and Related Rights in
the Work (i) in all territories worldwide, (ii) for the maximum duration
provided by applicable law or treaty (including future time extensions), (iii)
in any current or future medium and for any number of copies, and (iv) for any
purpose whatsoever, including without limitation commercial, advertising or
promotional purposes (the "License"). The License shall be deemed effective as
of the date CC0 was applied by Affirmer to the Work. Should any part of the
License for any reason be judged legally invalid or ineffective under
applicable law, such partial invalidity or ineffectiveness shall not
invalidate the remainder of the License, and in such case Affirmer hereby
affirms that he or she will not (i) exercise any of his or her remaining
Copyright and Related Rights in the Work or (ii) assert any associated claims
and causes of action with respect to the Work, in either case contrary to
Affirmer's express Statement of Purpose.

4. Limitations and Disclaimers.

a. No trademark or patent rights held by Affirmer are waived, abandoned,
surrendered, licensed or otherwise affected by this document.

b. Affirmer offers the Work as-is and makes no representations or warranties
of any kind concerning the Work, express, implied, statutory or otherwise,
including without limitation warranties of title, merchantability, fitness
for a particular purpose, non infringement, or the absence of latent or
other defects, accuracy, or the present or absence of errors, whether or not
discoverable, all to the greatest extent permissible under applicable law.

c. Affirmer disclaims responsibility for clearing rights of other persons
that may apply to the Work or any use thereof, including without limitation
any person's Copyright and Related Rights in the Work. Further, Affirmer
disclaims responsibility for obtaining any necessary consents, permissions
or other rights required for any use of the Work.

d. Affirmer understands and acknowledges that Creative Commons is not a
party to this document and has no duty or obligation with respect to this
CC0 or use of the Work.

For more information, please see
http://creativecommons.org/publicdomain/zero/1.0/

================================================================================
The 0BSD License applies to:

Expand Down
1 change: 1 addition & 0 deletions crates/typst-library/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ fn prelude(global: &mut Scope) {
global.define("green", Color::GREEN);
global.define("lime", Color::LIME);
global.define("luma", Color::luma_data());
global.define("oklab", Color::oklab_data());
global.define("rgb", Color::rgb_data());
global.define("cmyk", Color::cmyk_data());
global.define("range", Array::range_data());
Expand Down
2 changes: 1 addition & 1 deletion crates/typst-library/src/text/deco.rs
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ pub struct HighlightElem {
/// ```example
/// This is #highlight(fill: blue)[with blue].
/// ```
#[default(Color::Rgba(RgbaColor::new(0xFF, 0xFF, 0x5F, 0xFF)).into())]
#[default(Color::from_u8(0xFF, 0xFF, 0x5F, 0xFF).into())]
pub fill: Paint,

/// The top end of the background rectangle.
Expand Down
9 changes: 5 additions & 4 deletions crates/typst-library/src/text/raw.rs
Original file line number Diff line number Diff line change
Expand Up @@ -454,11 +454,12 @@ fn styled(piece: &str, foreground: Paint, style: synt::Style) -> Content {
body
}

fn to_typst(synt::Color { r, g, b, a }: synt::Color) -> RgbaColor {
RgbaColor { r, g, b, a }
fn to_typst(synt::Color { r, g, b, a }: synt::Color) -> Color {
Color::from_u8(r, g, b, a)
}

fn to_syn(RgbaColor { r, g, b, a }: RgbaColor) -> synt::Color {
fn to_syn(color: Color) -> synt::Color {
let [r, g, b, a] = color.to_vec4_u8();
synt::Color { r, g, b, a }
}

Expand Down Expand Up @@ -628,7 +629,7 @@ fn item(
synt::ThemeItem {
scope: scope.parse().unwrap(),
style: synt::StyleModifier {
foreground: color.map(|s| to_syn(s.parse::<RgbaColor>().unwrap())),
foreground: color.map(|s| to_syn(s.parse::<Color>().unwrap())),
background: None,
font_style,
},
Expand Down
2 changes: 1 addition & 1 deletion crates/typst/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@ image = { version = "0.24", default-features = false, features = ["png", "jpeg",
indexmap = { version = "2", features = ["serde"] }
log = "0.4"
miniz_oxide = "0.7"
oklab = "1"
once_cell = "1"
pdf-writer = "0.8.1"
pixglyph = "0.2"
palette = { version = "0.7.3", default-features = false, features = ["approx", "libm"] }
regex = "1"
resvg = { version = "0.35.0", default-features = false, features = ["raster-images"] }
roxmltree = "0.18"
Expand Down
6 changes: 2 additions & 4 deletions crates/typst/src/doc.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@ use crate::export::PdfPageLabel;
use crate::font::Font;
use crate::geom::{
self, rounded_rect, Abs, Axes, Color, Corners, Dir, Em, FixedAlign, FixedStroke,
Geometry, Length, Numeric, Paint, Point, Rel, RgbaColor, Shape, Sides, Size,
Transform,
Geometry, Length, Numeric, Paint, Point, Rel, Shape, Sides, Size, Transform,
};
use crate::image::Image;
use crate::model::{Content, Location, MetaElem, StyleChain};
Expand Down Expand Up @@ -352,8 +351,7 @@ impl Frame {
0,
Point::zero(),
FrameItem::Shape(
Geometry::Rect(self.size)
.filled(RgbaColor { a: 100, ..Color::TEAL.to_rgba() }.into()),
Geometry::Rect(self.size).filled(Color::TEAL.with_alpha(0.5).into()),
Span::detached(),
),
);
Expand Down
9 changes: 9 additions & 0 deletions crates/typst/src/eval/func.rs
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,15 @@ impl PartialEq for Func {
}
}

impl PartialEq<&NativeFuncData> for Func {
fn eq(&self, other: &&NativeFuncData) -> bool {
match &self.repr {
Repr::Native(native) => native.function == other.function,
_ => false,
}
}
}

impl From<Repr> for Func {
fn from(repr: Repr) -> Self {
Self { repr, span: Span::detached() }
Expand Down
2 changes: 0 additions & 2 deletions crates/typst/src/eval/value.rs
Original file line number Diff line number Diff line change
Expand Up @@ -604,7 +604,6 @@ primitive! { Plugin: "plugin", Plugin }
mod tests {
use super::*;
use crate::eval::{array, dict};
use crate::geom::RgbaColor;

#[track_caller]
fn test(value: impl IntoValue, exp: &str) {
Expand All @@ -623,7 +622,6 @@ mod tests {
test(Ratio::one() / 2.0, "50%");
test(Ratio::new(0.3) + Length::from(Abs::cm(2.0)), "30% + 56.69pt");
test(Fr::one() * 7.55, "7.55fr");
test(Color::Rgba(RgbaColor::new(1, 1, 1, 0xff)), "rgb(\"#010101\")");

// Collections.
test("hello", r#""hello""#);
Expand Down