-
-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cached export for incremental #2400
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The memoize annotations on render and svg functions still need to be removed (but you probably know that).
crates/typst-cli/src/compile.rs
Outdated
// If the frame is in the cache, skip it. | ||
if export_cache.is_cached(frame) { | ||
continue; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just thinking that this might be problematic if the file has been deleted in the meantime. Maybe we could check that it is still present with the correct mtime?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a check that the file exist, but I did not add the modified time check as I feel like this is
a) beyond scope since we'd need to keep track of time which I feel is unnecessary complexity
b) unnecessary, if the person messes up their files, it's on them, and otherwise the file would be overwritten anyway and they would lose their modification
Unless you feel very strongly about this, I'd leave it as is
Damn, I did it then I messed up my git and didn't migrate it 😠 |
Thank you again! |
See #2393