Replace Vec
with EcoVec
, removed Box
#2420
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2393.
As it turns out, errors are not so cheap to clone and not so rare: delayed errors can create large amounts of
SourceDiagnostic
s that are cloned in function calls and processed as delayed errors, this means that the extra level of indirection (theBox<..>
that used to be surrounding errors inSourceResult<T>
) and the expensive cloning (memcpy
over the entire contents) were expensive on documents that make use of delayed errors a lot (citations/refs inside oflocate
).