Refactor math styling to bring it closer to normal styling #3262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dherse
pushed a commit
to Dherse/typst
that referenced
this pull request
Feb 4, 2024
frozolotl
added a commit
to frozolotl/typst
that referenced
this pull request
Apr 4, 2024
…se I think it is a bit clearer, the word reads nicer (“overshell” vs “overturtle”), and there is no associated discussion (they are called “tortoise shells” in Unicode): > tortoises and turtles are not the same thing! ~ @Enivex There will be a sibling PR to rename the symbols too. Additionally, I refactored some code to make it more readable. I also fixed a bug introduced in typst#3262 where the wrong script style was being used. Closes typst#3856.
frozolotl
added a commit
to frozolotl/typst
that referenced
this pull request
Apr 4, 2024
I decided to use the word `shell` instead of turtle or tortoise because I think it is a bit clearer, the word reads nicer (“overshell” vs “overturtle”), and there is no associated discussion (they are called “tortoise shells” in Unicode): > tortoises and turtles are not the same thing! ~ @Enivex There will be a sibling PR to rename the symbols too. Additionally, I refactored some code to make it more readable. I also fixed a bug introduced in typst#3262 where the wrong script style was being used. Closes typst#3856.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings math a bit closer to the rest of Typst by removing the MathContext-based styling in favor of normal StyleChain stuff. The style chain resolving might be more costly than what we had before, but I haven't optimized this at all because math needs further refactoring before performance can become a focus.
What's nice is that
show math.equation: math.displaynow works because it just applies a style rather than creating a new element that is equation-ified and rematches.