Support Line decoration for Math [1/2] : Support Highlight for inline and block math equations #3941
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first of two PR for solving #2200
Regarding #2200, it turns out the highlight is supported for normal text but not for math equations. Digging into it, there are two aspect of it:
Note 1
for line based decorations, highlight is a rectangle added to the background of the targeted frame (be it normal text or math equations), so we "prepend" it (adding it beneath the frame), but for other line based decorations, it is **ON TOP OF" the targeted frame. It becomes kind of tricky and thus will be tackled in a next PR
Note 2
A new decoration function is introduced in this PR; the end goal is to merge the new one with the exiting old one. Such refactoring will be included in next PR.
Scope
what is in this MR:
what is not in this MR:
What will be in the second PR