Add crossmark symbol sym.rs

[giannissc]

No description provided.

[Enivex]

I would suggest changing these to mark.cross and mark.check

[giannissc]

Ready! 🙂 @Enivex

[giannissc]

Ready!

[Coekjan]

Looks good to me.

I am not the author/collaborator of the repo, so you still need to wait for their reviews.

[laurmaedje]

@Enivex there is also refmark and servicemark further below, so changing checkmark to mark.check maybe makes that a little inconsistent? It's probably also a bit harder to find mark.check than checkmark.

[Enivex]

@Enivex there is also refmark and servicemark further below, so changing checkmark to mark.check maybe makes that a little inconsistent? It's probably also a bit harder to find mark.check than checkmark.

I don't think so. Reference mark and service mark seem to fulfil entirely different roles than a check mark, so I'm not sure they belong together. On the other hand, a cross mark and check mark definitely do.

I think most people should just search for "check" or "mark" anyway.

[laurmaedje]

I didn't mean to imply that they belong together, more that mark is maybe a little to general as a parent for mark.check since there are so many other kinds of marks. So maybe checkmark and crossmark would be more consistent.

[Enivex]

I didn't mean to imply that they belong together, more that mark is maybe a little to general as a parent for mark.check since there are so many other kinds of marks. So maybe checkmark and crossmark would be more consistent.

They could be grouped under ballot instead?

[laurmaedje]

The existing ballot symbols all have the box as part of the glyph, so I think that would also be a bit inconsistent. Naming symbols is really tricky ^^

[Enivex]

The existing ballot symbols all have the box as part of the glyph, so I think that would also be a bit inconsistent. Naming symbols is really tricky ^^

On the other hand, the Unicode name for the cross mark is ballot x 😛.

Feel free to do what you think is right. (It could always be changed later too.)

[laurmaedje]

I think for the time being, I'd prefer the original checkmark / crossmark. lt and gt are also not grouped under a shared parent, which is sort of similar I guess.

[laurmaedje]

Thanks!

[giannissc]

Let me know if you would like any other changes! @laurmaedje , @Enivex

[laurmaedje]

No, it's all good now. It will be merged automatically once CI has passed. :)