Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All features with indoor=* may not be polygons #4

Open
PanierAvide opened this issue Dec 1, 2019 · 1 comment
Open

All features with indoor=* may not be polygons #4

PanierAvide opened this issue Dec 1, 2019 · 1 comment
Labels

Comments

@PanierAvide
Copy link

Hello,

I had a bug report on OsmInEdit (indoor editor) due to a bug of rendering, which might happen partially due to this library. In fact, a feature having highway=corridor + indoor=yes tags is considered by this library as a polygon. However, highway features are most of the time polygons if they have a area=yes tag. And adding indoor=yes tag on highway feature is relatively common, and doesn't mean they become areas. I'm not sure of what should be the rule in the JSON file to say that :

  • Features with indoor tag are polygons
  • Except when they have a highway tag that make them a line

Best regards.

@tyrasd
Copy link
Owner

tyrasd commented Feb 16, 2022

Unfortunately, the simple heuristic used here doesn't allow to invalidate matches based on presence of further tags. 🤔

Related issue on iD's issue tracker: openstreetmap/iD#6800

@tyrasd tyrasd mentioned this issue Feb 16, 2022
@tyrasd tyrasd added the bug label Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants