Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide some way to get Process Id #40

Closed
aersam opened this issue Oct 1, 2019 · 4 comments · Fixed by #41
Closed

Provide some way to get Process Id #40

aersam opened this issue Oct 1, 2019 · 4 comments · Fixed by #41
Labels
enhancement

Comments

@aersam
Copy link
Contributor

aersam commented Oct 1, 2019

Hi there! Thanks for this greaty utility! It makes my life a lot easier :)
Is there a chance to get some after process Start Callback in order to get the process Id right after the start? I'd do a PR if desired :)
@aersam aersam mentioned this issue Oct 3, 2019
Merged
@aersam
Copy link
Contributor Author

aersam commented Oct 3, 2019

As I need it, i just implemented it :)

@Tyrrrz
Copy link
Owner

Tyrrrz commented Oct 3, 2019

Hey there.
Can you explain in more detail why you need this feature?

@aersam
Copy link
Contributor Author

aersam commented Oct 3, 2019

Well, the idea is that I can log this ProcessId to some db or file. If I'd like to kill the process from outside I can easily identify it. I actually use the cancellation token if ever possible, but we have to be really sure to be able to kill the job from outside if nothing else works.

@Tyrrrz
Copy link
Owner

Tyrrrz commented Oct 3, 2019 •
edited
Loading

Makes sense, thanks.

@Tyrrrz Tyrrrz closed this as completed in #41 Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Process Id to Cli
2 participants
@Tyrrrz @aersam