Support other fractal products (FM3) #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmcgain
force-pushed
the
allow-other-products
branch
from
20f48ec
to
ea8e87b
Compare
kmcgain
force-pushed
the
allow-other-products
branch
from
ea8e87b
to
ee700fa
Compare
|
How about using a default constructor arg rather than having two separate constructors? |
Merge duplciate constructors
|
Yep looks good |
|
Allow switching product version for FM3 support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fractal forum member was interested in FM3 support. This PR just adds a new constructor to allow the passing of sysex product version.
Backwards compatible as defaults to AxeFx 3.
Adds 1 byte, could replace some of the const static bytes with #defines to bring that down if this is an issue.