Added Windows support #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added windows support, see github.com/nsip/gommap for details.
windows support
runs same tests as gommap_test.go for the windows implementation. Does not test Advise() or IsResident() methods as not currenlty implemented. Tests will fail on non-windows build machine.
added windows test file
The relative import causes dep to fail and the tests were not properly building due to OS packaging issues.
Remove relative import and fix tests
|
@matt-farmer Awesome -- thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gommap implementation is a dependency in liftbridge and we needed the server to be able to run on windows.
We've added windows support, and the map has been tested in lift bridge and works well for us.
Our fork with details of the windows implementation can be found at nsip-fork, along with references to all the other prior-art packages we investigated to put this patch together.
This PR contains a test file for windows, but tests will fail on a non-windows build machine.