Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work properly on Neovim 0.6 #24

Closed
cuberiser opened this issue Dec 1, 2021 · 9 comments
Closed

Doesn't work properly on Neovim 0.6 #24

cuberiser opened this issue Dec 1, 2021 · 9 comments

Comments

@cuberiser
Copy link
Contributor

The script_path function returns my plugged directory with neovim 0.6 but the lua/cmp_tabnine directory in neovim 0.5.1.

@cuberiser
Copy link
Contributor Author

it's probably an issue of neovim 0.6 so I should open a PR instead adding neovim 0.6 support

@tzachar
Copy link
Owner

tzachar commented Dec 1, 2021

Im using the latest nightly and have no problems.

@cuberiser
Copy link
Contributor Author

I'm using the 0.6 stable

@tzachar
Copy link
Owner

tzachar commented Dec 1, 2021

i'll check

@tzachar
Copy link
Owner

tzachar commented Dec 1, 2021

:version                                                                                                                                                        
NVIM v0.6.0                                                                                                                                                     
Build type: RelWithDebInfo                                                                                                                                      
LuaJIT 2.1.0-beta3                                                                                                                                              
Compilation: /usr/bin/gcc-11 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -DNVIM_TS_HAS_SET_MATCH_LIMIT -O2 -g -Og -g -Wall -Wextra -pedantic -Wno-unused-parameter -Ws
trict-prototypes -std=gnu99 -Wshadow -Wconversion -Wmissing-prototypes -Wimplicit-fallthrough -Wvla -fstack-protector-strong -fno-common -fdiagnostics-color=alw
ays -DINCLUDE_GENERATED_DECLARATIONS -D_GNU_SOURCE -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -DMIN_LOG_LEVEL=3 -I/home/runner/work/neovim/neovim/buil
d/config -I/home/runner/work/neovim/neovim/src -I/home/runner/work/neovim/neovim/.deps/usr/include -I/usr/include -I/home/runner/work/neovim/neovim/build/src/nv
im/auto -I/home/runner/work/neovim/neovim/build/include                                                                                                         
Compiled by runner@fv-az65-618                                                                                                                                  
                                                                                                                                                                
Features: +acl +iconv +tui                                                                                                                                      
See ":help feature-compile"                                                                                                                                     
                                                                                                                                                                
   system vimrc file: "$VIM/sysinit.vim"                                                                                                                        
  fall-back for $VIM: "/home/runner/work/neovim/neovim/build/nvim.AppDir/usr/share/nvim"                                                                        
                                                                                                                                                                
Run :checkhealth for more info               

and no problem on my end

@cuberiser
Copy link
Contributor Author

cuberiser commented Dec 1, 2021

that's interesting, when I call vim.notify for the script_path function it returns different things on 0.5.1 and 0.6, I should probably just move my tabnine binaries for now and look into it later.

@cuberiser
Copy link
Contributor Author

I used local binaries_folder = fn.expand('<sfile>:p:h:h:h') .. get_path_separator() ..'binaries' instead of local binaries_folder = get_parent_dir(get_parent_dir(script_path())) .. 'binaries' for the binaries folder and now it works fine somehow.

@cuberiser cuberiser reopened this Dec 1, 2021
@tzachar
Copy link
Owner

tzachar commented Dec 1, 2021

This will not work in general.
See #4

And I also can't reproduce your issue with 0.6

@cuberiser
Copy link
Contributor Author

maybe a windows issue then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants