prepare for apps child PR #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzaffi
commented
Jun 7, 2023
| @@ -162,132 +164,55 @@ func MakeGenerator(dbround uint64, bkGenesis bookkeeping.Genesis, config Generat | |||
| return gen, nil | |||
| } | |||
|
|
|||
| // Generator is the interface needed to generate blocks. | |||
There was a problem hiding this comment.
generator_types.go is the new home for types/interfaces
|
Should this PR go upstream instead of into your other branch? |
I think this would have been a better approach, but since the config PR already had one approval, I didn't want to put something ahead of it that would require a new review. |
shiqizng
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is almost a no-op PR which just reorganizes the
generatormodule.It's a no-op except for the second commit which is a bugfix that appears in: algorand#5450