Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use constrain properly #1151

Merged
merged 2 commits into from Nov 22, 2020
Merged

Use constrain properly #1151

merged 2 commits into from Nov 22, 2020

Conversation

lbussy
Copy link
Contributor

@lbussy lbussy commented Nov 22, 2020

As written, the way constrain is used has no effect/unintended effect and will generate the following warnings:

warning: second operand of conditional expression has no effect [-Wunused-value]
warning: third operand of conditional expression has no effect [-Wunused-value]

This change addresses those warnings and corrects the behavior.

@tablatronix
Copy link
Collaborator

Thanks, no idea why I thought it was edit by reference, been using php too much lately.. lol

@tablatronix tablatronix merged commit b550876 into tzapu:development Nov 22, 2020
@lbussy
Copy link
Contributor Author

lbussy commented Nov 22, 2020

I stared at it for a while wondering what was wrong. Looked legit to me as well.

@lbussy lbussy deleted the development branch November 22, 2020 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants