Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for WifiManager as ESP-IDF component #1489

Merged
merged 1 commit into from Oct 4, 2022
Merged

Support for WifiManager as ESP-IDF component #1489

merged 1 commit into from Oct 4, 2022

Conversation

abrender
Copy link
Contributor

Enables support for WifiManager as an ESP-IDF component. ESP-IDF is a popular development framework for ESP32 chips.

This file is based on the CMakeLists.txt file from the popular Adafruit-GFX-Library library.

Enables support for WifiManager as an ESP-IDF component.  ESP-IDF is a popular development framework for ESP32 chips.

This file is based on the CMakeLists.txt file from the popular Adafruit-GFX-Library library.
@tablatronix tablatronix added the enhancement Feature Request label Sep 12, 2022
@abrender
Copy link
Contributor Author

Hey @tablatronix is there anything that I should to in order to run the workflow or help get this merged in? Thanks in advance!

@tablatronix
Copy link
Collaborator

Yeah sorry I was looking this over I have not used idf much

@abrender
Copy link
Contributor Author

Yeah sorry I was looking this over I have not used idf much

I was not familiar with it either, but I found that Adafruit-GFX-Library has this file (https://github.com/adafruit/Adafruit-GFX-Library/blob/master/CMakeLists.txt) and I created one for WiFiManager and it works well :)

@letis009
Copy link

letis009 commented Sep 30, 2022

@abrender this is awesome, I was pretty desperate to get this library working with ESP-IDF. Loading the WifiManager codebase into component/arduino/library and adding relative paths to arduino CMakeLists.txt and create a CMakeLists.txt inside WiFiManager it compiles and works well

@abrender
Copy link
Contributor Author

abrender commented Oct 1, 2022

@letis009 You will need to clone this repo into your project's components directory (or add it as a git submodule git submodule add https://github.com/tzapu/WiFiManager.git components/WiFiManager).

After this pull requested is merged in you can update your main/CMakeLists.txt file to have:

idf_component_register(
  # Rest of your stuff here
  REQUIRES WiFiManager
)

Until this pull request is merged in, you can update your main/CMakeLists.txt to look like this one in the mariobros-clock project: https://github.com/jnthas/mariobros-clock/blob/4980007f7efb6980b2b1385dc9e5f42997c14340/main/CMakeLists.txt

@tablatronix
Copy link
Collaborator

So this is pretty innoculous? I can safely merge yhis without testing?

@letis009
Copy link

letis009 commented Oct 1, 2022

Ive done a far bit of testing on ESP32-wrover-kit amd ESP32-c3 modules and have awesome results. Seems to have sorted the issue with soft-ap not starting as well. I copied the beta 13 into components/arduino and added the directory to arduino/CMakes file. Build , flash and good to go

@abrender
Copy link
Contributor Author

abrender commented Oct 1, 2022

So this is pretty innoculous? I can safely merge yhis without testing?

I believe so. I've been using it extensively. Also many major projects have a similar file - Adafruit-GFX-Library, ESP32-HUB75-MatrixPanel-DMA, Adafruit_BusIO, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants