Wifi manager frank cohen #1642
Merged
Wifi manager frank cohen #1642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested on ESP32-S3, so I added the ESP32-S3 shield to the readme
Added ESP32-S3 tag and fixed the release shield to not click away from the project.
czulykr
reviewed
Jan 20, 2024
| @@ -5,7 +5,8 @@ Espressif ESPx WiFi Connection manager with fallback web configuration portal | |||
|
|
|||
| :warning: This Documentation is out of date, see notes below | |||
|
|
|||
|  | |||
| <a name="release"></a> | |||
There was a problem hiding this comment.
Suggested change
| <a name="release"></a> | |
| <a name="release"></a> |
czulykr
reviewed
Jan 20, 2024
| @@ -5,7 +5,8 @@ Espressif ESPx WiFi Connection manager with fallback web configuration portal | |||
|
|
|||
| :warning: This Documentation is out of date, see notes below | |||
|
|
|||
|  | |||
There was a problem hiding this comment.
Suggested change
|  | |
|  |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for the great library. Here's a tiny contribution in return. I tested on ESP32-S3 so the readme now has the shield for ESP32-S3. And I fixed the Release shield from clicking to the image page. -Frank