Support Windows #11
Open
Support Windows #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If anyone else runs into this, in order to make this fix easier to use I've published a temporary fork of the project to npm. https://www.npmjs.com/package/@jagthedrummer/ember-heroicons |
@jagthedrummer I'll try to take a look at this PR so we can get it into this repo. Thanks and apologies for the delay! |
|
No worries, @tzellman! I know how it goes. Thanks for the excellent add-on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10
The
globpackage doesn't work with paths that contain back slashes as separators. So to get the icons list to populate properly on Windows we need to convert back slashes to forward slashes before passing the path toglobSync.From the
globREADME