Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build fails for ember-release channel #112

Closed
tzellman opened this issue May 10, 2021 · 0 comments · Fixed by #113
Closed

build fails for ember-release channel #112

tzellman opened this issue May 10, 2021 · 0 comments · Fixed by #113
Assignees
Labels
bug Something isn't working

Comments

@tzellman
Copy link
Owner

This is due to an issue with ember-moment, reported here: adopted-ember-addons/ember-moment#340

For now, we can allow the release channel to fail (mark as experimental in CI) or remove ember-moment (only used in the dummy app / tests).

@tzellman tzellman added the bug Something isn't working label May 10, 2021
@tzellman tzellman self-assigned this May 10, 2021
tzellman added a commit that referenced this issue May 10, 2021
- was failing the release channel build (adopted-ember-addons/ember-moment#340)
- only used in the dummy app
- replaced with a simple helper that uses moment directly (via auto-import)

fixes #112
tzellman added a commit that referenced this issue May 10, 2021
- was failing the release channel build (adopted-ember-addons/ember-moment#340)
- only used in the dummy app
- replaced with a simple helper that uses moment directly (via auto-import)

fixes #112
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant