Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this is the first attempt to update the test suite to Minitest 5. We are going to upgrade Ruby on Rails in Fedora 21 and RoR 4.1 uses the new Minitest so we upgraded it as well. We would love to see gems to use the new Minitest not to carry patches or sticking with the old one.
What this PR changes?
require 'test/unit'
torequire 'minitest/autorun'
Test::Unit::TestCase
toMinitest::Test
assert_not_nil
torefute_nil
.gemspec
assert_nothing_raised
,assert_not_same
, andassert_block
to other custom asserts extendingKernel
intest/test_utils.rb
. This is kind of backport from older Minitest and we can probably change the tests not to use those at all in future.Please consider.