Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use {from,to}_chars instead of the Spirit X3 number parsers. #113

Closed
tzlaine opened this issue Feb 24, 2024 · 1 comment
Closed

Use {from,to}_chars instead of the Spirit X3 number parsers. #113

tzlaine opened this issue Feb 24, 2024 · 1 comment

Comments

@tzlaine
Copy link
Owner

tzlaine commented Feb 24, 2024

This could be std:: or boost::charconv::, whichever is available.

@tzlaine
Copy link
Owner Author

tzlaine commented Feb 26, 2024

I'm less hot on this idea after looking at from_chars:

std::from_chars_result
    from_chars( const char* first, const char* last,
                /* integer-type */& value, int base = 10 );

So for this to work, the parse input would need to be a common_range. Additionally, it would need to be chars, or a transcoding range that has chars at bottom.

Also, it would only have the same behavior when MinDigits and/or MaxDigits are not in use.

Ok, I guess it's not that limiting. I guess most input will be in chars, transcoded or not.

tzlaine added a commit that referenced this issue Feb 26, 2024
…om_chars,

if available; otherwise, use the Spirit X3 number parsers.

Fixes #113.
tzlaine added a commit that referenced this issue Feb 26, 2024
…om_chars,

if available; otherwise, use the Spirit X3 number parsers.

Fixes #113.
tzlaine added a commit that referenced this issue Mar 2, 2024
…om_chars,

if available; otherwise, use the Spirit X3 number parsers.

Fixes #113.
tzlaine added a commit that referenced this issue Mar 2, 2024
…om_chars,

if available; otherwise, use the Spirit X3 number parsers.

Fixes #113.
tzlaine added a commit that referenced this issue Mar 2, 2024
…om_chars,

if available; otherwise, use the Spirit X3 number parsers.

Fixes #113.
tzlaine added a commit that referenced this issue Mar 2, 2024
…om_chars,

if available; otherwise, use the Spirit X3 number parsers.

Fixes #113.
tzlaine added a commit that referenced this issue Mar 3, 2024
…om_chars,

if available; otherwise, use the Spirit X3 number parsers.

Fixes #113.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant