Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated/removed cmake modules #98

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Conversation

mborland
Copy link

Fixes: "Policy CMP0148 is not set: The FindPythonInterp and FindPythonLibs modules
are removed. Run "cmake --help-policy CMP0148" for policy details. Use
the cmake_policy command to set the policy and suppress this warning."

PythonInterp was deprecated in 3.12 and removed in 3.27

@Flamefire
Copy link

Why is this even required? Neither PYTHON_EXECUTABLE nor PYTHON3_EXECUTABLE are used so I'd just remove this part of the code which looks like some leftover

@tzlaine
Copy link
Owner

tzlaine commented Feb 24, 2024

That's a good point; it's not required here. It's just part of some boilerplate CMake that I copy around from project to project, and I never removed it here, nor used it.

CMakeLists.txt Outdated Show resolved Hide resolved
Co-authored-by: Alexander Grund <Flamefire@users.noreply.github.com>
@tzlaine
Copy link
Owner

tzlaine commented Feb 27, 2024

Thanks!

@tzlaine tzlaine merged commit 3c3e44e into tzlaine:develop Feb 27, 2024
@mborland mborland deleted the CML branch February 27, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants