-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rustler precompiled fails to verify NIF checksum #35
Comments
And one side question. I believe with precompiled NIFs it is not required for library users, since rust code is already compiled. |
Hey @inaniyants, Thanks for opening this and pointing the problem out! I missed that line in the README.md, I'll update, you definitely don't need Rust unless you want to force compile. Let me do some digging here on the checksum. I definitely think publishing to hex would be nice as part of the action. |
It looks like the authors of the rustler-precompiled did intend for everyone to check-in the checksum file in the repos. That's what I saw in all the libraries that I checked as well. The mismatch is a problem for sure, I'm going to figure out a solution to make sure this doesn't happen in the future. |
I think there it is meant to include file into hex repo, but not into source code repo. Here is ref, where I originally found recommendation to not include it to source code repo
|
Probably this will help |
I just pushed a 0.7.1 update with the right checksums, do you mind re-running your CI with the version bump to see if that fixes it ? |
Yeah, new build is ok |
Hello and thanks for delivering such useful update as precompiled NIFs!
It looks like 0.7.0 release on hex contains wrong checksums file.
You can see, that some dependent packages are failing to update to 0.7.0 , like in this PR
poanetwork/ex_abi#122
I have few suggestions:
release: mix rustler_precompiled.download ExKeccak --all --print mix hex.publish --yes
then just
make release
.In such way won't be needed to commit checksums on each release and won't forget to update it before publishing to hex.
The text was updated successfully, but these errors were encountered: