Fix warning with logging off in GNSS and Wifi: unused variables. (#759)

In two places, one in GNSS and one in Wi-Fi, a variable was used only in the logging code and hence when logging is compiled out a warning was emitted. With this commit the "build with logging off" tests is updated to include a check for unused variables and the two occurrences are fixed.
u-blox · Jan 5, 2023 · 4889b44 · 4889b44
1 parent 9e738a7
commit 4889b44
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/common/network/src/u_network_private_wifi.c b/common/network/src/u_network_private_wifi.c
@@ -182,7 +182,7 @@ static void wifiConnectionCallback(uDeviceHandle_t devHandle,
         }
     }
 
-#if defined(U_CFG_ENABLE_LOGGING) && !U_CFG_OS_CLIB_LEAKS
+#if U_CFG_ENABLE_LOGGING && !U_CFG_OS_CLIB_LEAKS
     if (status == U_WIFI_CON_STATUS_CONNECTED) {
         uPortLog(LOG_TAG "Wifi connected connId: %d, bssid: %s, channel: %d\n",
                  connId,

diff --git a/gnss/src/u_gnss.c b/gnss/src/u_gnss.c
@@ -63,6 +63,7 @@
  * STATIC VARIABLES
  * -------------------------------------------------------------- */
 
+#if U_CFG_ENABLE_LOGGING
 /** To display some nice text.
  */
 //lint -esym(752, gpTransportTypeText) Suppress not referenced, which
@@ -75,6 +76,7 @@ static const char *const gpTransportTypeText[] = {"None",       // U_GNSS_TRANSP
                                                   "UBX UART",   // U_GNSS_TRANSPORT_UBX_UART
                                                   "UBX I2C"     // U_GNSS_TRANSPORT_UBX_I2C
                                                  };
+#endif
 
 /* ----------------------------------------------------------------
  * STATIC FUNCTIONS

diff --git a/port/platform/static_size/Makefile b/port/platform/static_size/Makefile
@@ -36,7 +36,7 @@ endif
 SILENT = @
 
 # Compiler flags
-override CFLAGS += -Os -g0
+override CFLAGS += -Os -g0 -Wall -Werror
 LDFLAGS += -Wl,--cref --specs=nano.specs -lc -lnosys
 
 # Compiler flags for no float