Skip to content

Commit

Permalink
mmc: sdhci: Correct ADMA_DESC_LEN to 12
Browse files Browse the repository at this point in the history
Commit 37cb626 ("mmc: sdhci: Add Support for ADMA2") introduced
ADMA_DESC_LEN == 16 (64 bit case), but it was never used before commit
74755c1 ("mmc: sdhci: introduce adma_write_desc() hook to struct sdhci_ops").

"sizeof(struct sdhci_adma_desc)" (== 12 for 64bit case) was used instead.

Confusion probably originates from Linux commit 685e444bbaa0
("mmc: sdhci: Add ADMA2 64-bit addressing support for V4 mode"), but
the latter "V4 mode" was never ported to U-Boot.

Fixes: 74755c1 ("mmc: sdhci: introduce adma_write_desc() hook to struct sdhci_ops")
Signed-off-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
Tested-by: Jonathan Humphreys <j-humphreys@ti.com>
Tested-by: Judith Mendez <jm@ti.com>
  • Loading branch information
ccpalex authored and trini committed May 2, 2024
1 parent 62825d4 commit c92d48f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion include/sdhci.h
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ struct sdhci_ops {

#define ADMA_MAX_LEN 65532
#ifdef CONFIG_MMC_SDHCI_ADMA_64BIT
#define ADMA_DESC_LEN 16
#define ADMA_DESC_LEN 12
#else
#define ADMA_DESC_LEN 8
#endif
Expand Down

0 comments on commit c92d48f

Please sign in to comment.