common/memsize.c: Fix get_ram_size() when cache is enabled #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eghidoli
force-pushed
the
check_get_mem_size
branch
5 times, most recently
from
e753179
to
941004d
Compare
Build fail if CONFIG_SANDBOX_SDL is disabled due to ENOSYS undeclared. Include errno.h before including test/lib.h. Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
This adds dcache_status() so that code using it can build without error on sandbox. Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
Ensure that every write is flushed to memory and afterward reads are from memory. Since the algorithm rely on the fact that accessing to not existent memory lead to write at addr / 2 without this modification accesses to aliased (not physically present) addresses are cached and wrong size is returned. This was discovered while working on a TI AM625 based board where cache is normally enabled, see commit c02712a ("arm: mach-k3: Enable dcache in SPL"). Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
eghidoli
force-pushed
the
check_get_mem_size
branch
from
941004d
to
9ead36e
Compare
|
commits will be posted to mailing list. I create this MR just for CI tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that every write is flushed to memory and afterward reads are from memory.
Since the algorithm rely on the fact that accessing to not existent memory lead to write at addr / 2 without this modification accesses to aliased (not physically present) addresses are cached and wrong size is returned.
This was discovered while working on a TI AM625 based board where cache is normally enabled, see commit c02712a ("arm: mach-k3: Enable dcache in SPL").
Please do not submit a Pull Request via github. Our project makes use of
mailing lists for patch submission and review. For more details please
see https://u-boot.readthedocs.io/en/latest/develop/sending_patches.html
The only exception to this is in order to trigger a CI loop on Azure prior
to posting of patches.