Remove handler interface, mock and related tests.

Signed-off-by: Christopher Meis <christopher.meis@9elements.com>

pkg/ipmi/handler.go

@@ -36,10 +36,3 @@ func (r *realSyscalls) fileSetReadDeadline(f *os.File, t time.Duration) error {
 func (r *realSyscalls) connRead(f func(fd uintptr) bool, conn syscall.RawConn) error {
 	return conn.Read(f)
 }
-
-type handler interface {
-	SendRequest(*request) error
-	ReceiveResponse(int64, *response, []byte) ([]byte, error)
-	File() *os.File
-	Close() error
-}

pkg/ipmi/ipmi.go

@@ -30,7 +30,7 @@ var (
 
 // IPMI represents access to the IPMI interface.
 type IPMI struct {
-	handler
+	*dev
 }
 
 // SendRecv sends the IPMI message, receives the response, and returns the
@@ -66,7 +66,7 @@ func (i *IPMI) RawSendRecv(msg Msg) ([]byte, error) {
 
 	// Send request.
 	for {
-		switch err := i.handler.SendRequest(req); {
+		switch err := i.dev.SendRequest(req); {
 		case err == syscall.EINTR:
 			continue
 		case err != nil:
@@ -86,7 +86,7 @@ func (i *IPMI) RawSendRecv(msg Msg) ([]byte, error) {
 		msg:     recvMsg,
 	}
 
-	return i.handler.ReceiveResponse(req.msgid, recv, buf)
+	return i.dev.ReceiveResponse(req.msgid, recv, buf)
 }
 
 func (i *IPMI) WatchdogRunning() (bool, error) {
@@ -352,5 +352,5 @@ func (i *IPMI) RawCmd(param []byte) ([]byte, error) {
 
 // Close closes the file attached to ipmi
 func (i *IPMI) Close() error {
-	return i.handler.Close()
+	return i.dev.Close()
 }

pkg/ipmi/ipmi_linux.go

@@ -18,5 +18,5 @@ func Open(devnum int) (*IPMI, error) {
 		return nil, err
 	}
 
-	return &IPMI{handler: newDev(f)}, nil
+	return &IPMI{dev: newDev(f)}, nil
 }