New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant implementation of rsdp in pkg/boot/acpi #2164
Conversation
CircleCi doesn't kick off |
This is a weird bug in CircleCi. The CI is not being run in the u-root organization (https://app.circleci.com/pipelines/github/u-root/u-root) and is instead being run in the 9elements organization (https://app.circleci.com/pipelines/github/9elements/u-root). Since it is being run under the wrong CircleCI organization, the results are not finding their way back to the pull request. The only way I know to fix this is to delete the CircleCI organization for 9elements (https://app.circleci.com/pipelines/github/9elements/u-root) or to create a new Github repository to send the PR from. Once that is done, push an empty commit to the PR to re-trigger it. |
Ah... can it be that 9elements has something set so that all their repos automatically get Circle CI integrated? I have some vague memory that there is such an org-wide setting. It might be that it can't be changed. I'd also suggest using another fork, maybe just from personal accounts. |
Yes, trying again from another fork should work. This has happened a few times before with different folks. I'm not sure exactly what triggers it. Somehow the 9elements/u-root CircleCI is taking priority over the u-root/u-root CirclecCI. |
CircleCI has a setting to build all forks of a project from the organization I guess this is what is happening here. Otherwise, CircleCI changed their policies recently and it is not possible to build any step that takes more then 2 hours. Looking for answers myself for open source projects like Heads here on how to go from here. If this is related don't hesitate to tag me for follow ups. |
Signed-off-by: Christopher Meis <christopher.meis@9elements.com>
So. The simple fix is to push our branch directly to u-root repo instead of opening the PR from our repo to u-root. This at least avoids the problem for now. |
Signed-off-by: Christopher Meis christopher.meis@9elements.com