Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmds/core/find: move command from main and add tests #2619

Merged
merged 3 commits into from
Feb 17, 2023

Conversation

binjip978
Copy link
Contributor

No description provided.

Signed-off-by: Siarhiej Siemianczuk <pdp.eleven11@gmail.com>
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Base: 74.90% // Head: 74.89% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (7773168) compared to base (8a02784).
Patch coverage: 62.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2619      +/-   ##
==========================================
- Coverage   74.90%   74.89%   -0.01%     
==========================================
  Files         409      410       +1     
  Lines       41427    41489      +62     
==========================================
+ Hits        31031    31075      +44     
- Misses      10396    10414      +18     
Impacted Files Coverage Δ
cmds/core/find/find.go 72.58% <62.50%> (ø)
cmds/core/mv/mv.go 77.27% <0.00%> (-2.28%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@binjip978 binjip978 added the Awaiting reviewer Waiting for a reviewer. label Feb 16, 2023
cmds/core/find/find.go Outdated Show resolved Hide resolved
cmds/core/find/find.go Show resolved Hide resolved
cmds/core/find/find.go Outdated Show resolved Hide resolved
cmds/core/find/find.go Show resolved Hide resolved
@rminnich rminnich added Awaiting author Waiting for new changes or feedback for author. and removed Awaiting reviewer Waiting for a reviewer. labels Feb 16, 2023
remove stdin, not used stderr in tests
move flag vars to main function
move args at the end

Signed-off-by: Siarhiej Siemianczuk <pdp.eleven11@gmail.com>
@binjip978 binjip978 added Awaiting reviewer Waiting for a reviewer. and removed Awaiting author Waiting for new changes or feedback for author. labels Feb 17, 2023
@binjip978 binjip978 merged commit ea2954b into u-root:main Feb 17, 2023
@binjip978 binjip978 deleted the find-tests branch February 17, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting reviewer Waiting for a reviewer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants