boot: improved Load API #2620
Merged
boot: improved Load API #2620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 74.90% // Head: 75.08% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2620 +/- ##
==========================================
+ Coverage 74.90% 75.08% +0.18%
==========================================
Files 410 408 -2
Lines 41489 41370 -119
==========================================
- Hits 31076 31063 -13
+ Misses 10413 10307 -106
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
verbose and dryRun will for the most part be set through boolean flags, so a boolean WithVerbose(bool) and WithDryRun(bool) should be available for easy use. Signed-off-by: Chris Koch <chrisko@google.com>
rminnich
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
verbose and dryRun will for the most part be set through boolean flags, so a boolean WithVerbose(bool) and WithDryRun(bool) should be available for easy use.