Dd for tinygo #2646
Merged
Dd for tinygo #2646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change requires removing globals that are written to a run() function. This has the side effect of making parallel testing work (probably) and removing testutil. The code is arguably ugly, but I figure reviewers will show better ways to do things. Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
progress package now has a New(), the ProgressData is an exported type, and the struct contains the io.Writer. This way, we no longer gets lots of junk output during tests. Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2646 +/- ##
==========================================
- Coverage 75.13% 75.02% -0.11%
==========================================
Files 411 413 +2
Lines 41614 41760 +146
==========================================
+ Hits 31266 31331 +65
- Misses 10348 10429 +81
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
This changes lets the test finish with tinycore. Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
rminnich
added
automerge
binjip978
reviewed
Apr 1, 2023
binjip978
reviewed
Apr 1, 2023
binjip978
reviewed
Apr 1, 2023
Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
binjip978
approved these changes
Apr 1, 2023
binjip978
added
Awaiting author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dd fixes for tinygo. These are pretty minimal to get it to go at all, but they have the nice side effect of removing testutil and allowing concurrency in tests.
The unit package adds a good 11K to the binary when built with tinygo. It's not entirely clear that we need what it does, but for now, it remains.
Due to some odd limitations in tinygo, the final test memory footprint had to be reduce from 1G to 1/4 G, but I doubt this changes the validity of the test.
This change will also allow dd to be built into the 'forkless' environment.