Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/uzip: remove deprecated #2648

Merged
merged 1 commit into from
Apr 8, 2023
Merged

pkg/uzip: remove deprecated #2648

merged 1 commit into from
Apr 8, 2023

Conversation

binjip978
Copy link
Contributor

No description provided.

@binjip978 binjip978 added the Awaiting reviewer Waiting for a reviewer. label Apr 6, 2023
rminnich
rminnich reviewed Apr 7, 2023
View reviewed changes
Copy link
Member

@rminnich rminnich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you make this description a little more verbose?
maybe
change deprecated os.SEEK_END, ioutil.ReadFile, and ioutil.TempFile uses

@binjip978
pkg/uzip: remove deprecated package and constant
3de7720 
os.SEEK_END -> io.SeekEnd
ioutil.ReadFile -> os.ReadFile
ioutil.TempFile -> os.CreateTemp

Signed-off-by: Siarhiej Siemianczuk <pdp.eleven11@gmail.com>
@binjip978
Copy link
Contributor Author

binjip978 commented Apr 7, 2023 •
edited
Loading

could you make this description a little more verbose?
maybe
change deprecated os.SEEK_END, ioutil.ReadFile, and ioutil.TempFile uses

sure updated, unfortunately due force push I don't see it in description, but it should be in commit.

pkg/uzip: remove deprecated package and constant
os.SEEK_END -> io.SeekEnd
ioutil.ReadFile -> os.ReadFile
ioutil.TempFile -> os.CreateTemp

@binjip978 binjip978 merged commit f020e92 into u-root:main Apr 8, 2023
@binjip978 binjip978 deleted the uzip-deprecation branch April 8, 2023 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rminnich rminnich rminnich approved these changes

Assignees
No one assigned
Labels
Awaiting reviewer Waiting for a reviewer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@binjip978 @rminnich