pkg/boot/grub: Add multiboot2 and module2 grub keywords #2664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnylinwiwynn
previously approved these changes
Apr 27, 2023
rminnich
added
the
Awaiting author
|
I'm going to assume this was tested, but I wonder if you could look at adding a test? |
|
Yes this was tested, it can boot the TBOOT we installed which requires multiboot2 keywords. Will try to add a test. |
|
A small nit: There is a typo in mudule2 in one commit message summary/title and the merge/pull request summary/title. |
rminnich
approved these changes
May 2, 2023
|
If you wish to change mudule2 in the commit message, I can reapprove this PR, but if I see no comments in a day, I will merge it. |
ShellyChang110
changed the title
Signed-off-by: Shelly Chang <Shelly_Chang@wiwynn.com>
It adds the test data for the grub `multiboot2` and `module2` keywords. The data is generated from CentOS 8 Stream with GRUB_ENABLE_BLSCFG set to true and TBOOT installed. Signed-off-by: Shelly Chang <Shelly_Chang@wiwynn.com>
ShellyChang110
force-pushed
the
fix-multiboot2
branch
from
0cdb7a4
to
a6c3204
Compare
We have updated the commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.