Idea on how to fix: fork syscall bug #2671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmin1
changed the title
rminnich
added
the
Awaiting author
|
Concept ACK, but would be nice to add the |
rminnich
reviewed
May 2, 2023
|
yes, please add a test. |
|
Alright, I will work on that |
robertmin1
force-pushed
the
fork_bug
branch
3 times, most recently
from
ca04287
to
fc07b2f
Compare
Signed-off-by: robertmin1 <104002271+robertmin1@users.noreply.github.com>
|
Since the current |
robertmin1
added
Awaiting reviewer
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2671 +/- ##
==========================================
+ Coverage 75.43% 75.49% +0.05%
==========================================
Files 413 413
Lines 41963 41964 +1
==========================================
+ Hits 31654 31679 +25
+ Misses 10309 10285 -24
☔ View full report in Codecov by Sentry. |
rminnich
approved these changes
May 19, 2023
rminnich
approved these changes
May 19, 2023
rminnich
added
automerge
This was referenced May 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding unix.PTRACE_O_TRACEEXEC to the Ptrace Options fixes the fork issue. This will enable us to avoid seeing the SIGTRAP signal. This option tells ptrace to generate a SIGTRAP signal immediately before a new program is executed with the execve system call.
Fixes: #2670 #2635 and #2590
Signed-off-by: Robert Mindo mindo.robert1@gmail.com