Add basic GRUB default boot entry support #2693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShellyChang110
changed the title
ShellyChang110
force-pushed
the
boot-default-option
branch
from
3348316
to
71cd90d
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2693 +/- ##
==========================================
+ Coverage 72.45% 75.40% +2.94%
==========================================
Files 355 414 +59
Lines 37729 42116 +4387
==========================================
+ Hits 27337 31756 +4419
+ Misses 10392 10360 -32
☔ View full report in Codecov by Sentry. |
rminnich
reviewed
Jun 7, 2023
Signed-off-by: Shelly Chang <Shelly_Chang@wiwynn.com>
ShellyChang110
force-pushed
the
boot-default-option
branch
from
71cd90d
to
147226d
Compare
rminnich
reviewed
Jun 8, 2023
ShellyChang110
force-pushed
the
boot-default-option
branch
from
147226d
to
956a082
Compare
Add support for the default boot entry when GRUB_DEFAULT=saved and GRUB_ENABLE_BLSCFG=true in /etc/default/grub.
For this case grub.cfg would generate the below line:
set default="${saved_entry}"
and grubenv would contain the value of ${saved_entry}, which will be compared and used as the default boot entry.
Here it only handles specifically for this case.
The default boot entry will be assigned with an incremented linux.BootRank, therefore it will be displayed from the top of the boot menu.
Testing method:
With CentOS 8, set GRUB_DEFAULT=saved and GRUB_ENABLE_BLSCFG=true in /etc/default/grub, and then run 'grub2-mkconfig -o /boot/efi/EFI/centos/grub.cfg'.
Use 'grubby --set-default' to set the default boot option, run 'cat /boot/*/grubenv' to check the value after saved_entry is expected.
After reboot, 'boot' command can see the default boot option displayed at the top of the boot menu.
Signed-off-by: Shelly Chang <Shelly_Chang@wiwynn.com>
Signed-off-by: Shelly Chang <Shelly_Chang@wiwynn.com>
ShellyChang110
force-pushed
the
boot-default-option
branch
from
956a082
to
8ee4f6c
Compare
rminnich
approved these changes
Jun 9, 2023
Thanks for your review Ron. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.