Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/dt: look-up direct children and prune sub-trees #2708

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

DavidDecotigny
Copy link
Contributor

@DavidDecotigny DavidDecotigny commented Jun 27, 2023

A few minor extensions to the existing pkg/dt API to look-up direct children and prune sub-trees,

It is sometimes useful to look up a specific direct child of a given node, instead of recursively looking up a child at any depth in the tree. A 2nd patch adds the ability to edit the FDT to remove a node and its subtree.

@DavidDecotigny DavidDecotigny changed the title A few minor extensions to the existing pkg/dt API to look-up direct children and prune sub-trees pkg/dt: look-up direct children and prune sub-trees Jun 27, 2023
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.16 ⚠️

Comparison is base (a4c8814) 75.51% compared to head (43d0d8a) 75.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2708      +/-   ##
==========================================
- Coverage   75.51%   75.36%   -0.16%     
==========================================
  Files         414      414              
  Lines       42215    42231      +16     
==========================================
- Hits        31879    31826      -53     
- Misses      10336    10405      +69     
Impacted Files Coverage Δ
pkg/dt/node.go 50.64% <100.00%> (+5.64%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DavidDecotigny DavidDecotigny marked this pull request as ready for review June 27, 2023 01:48
@DavidDecotigny
Copy link
Contributor Author

Hello, could you please consider this PR to add 2 handy features to pkg/dt?

Thanks!

pkg/dt/node.go Outdated Show resolved Hide resolved
Signed-off-by: David Decotigny <ddecotig@google.com>
pkg/dt/node.go Outdated Show resolved Hide resolved
Signed-off-by: David Decotigny <ddecotig@google.com>
@hugelgupf
Copy link
Member

I'm good. Ron?

@rminnich
Copy link
Member

let's go!

@rminnich rminnich merged commit 9dddf41 into u-root:main Jun 27, 2023
24 checks passed
@DavidDecotigny
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants