-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/dt: look-up direct children and prune sub-trees #2708
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2708 +/- ##
==========================================
- Coverage 75.51% 75.36% -0.16%
==========================================
Files 414 414
Lines 42215 42231 +16
==========================================
- Hits 31879 31826 -53
- Misses 10336 10405 +69
☔ View full report in Codecov by Sentry. |
Hello, could you please consider this PR to add 2 handy features to pkg/dt? Thanks! |
rminnich
reviewed
Jun 27, 2023
f5ce997
to
9d4fbb1
Compare
Signed-off-by: David Decotigny <ddecotig@google.com>
9d4fbb1
to
a788a85
Compare
rminnich
reviewed
Jun 27, 2023
Signed-off-by: David Decotigny <ddecotig@google.com>
a788a85
to
43d0d8a
Compare
hugelgupf
approved these changes
Jun 27, 2023
I'm good. Ron? |
rminnich
approved these changes
Jun 27, 2023
let's go! |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few minor extensions to the existing pkg/dt API to look-up direct children and prune sub-trees,
It is sometimes useful to look up a specific direct child of a given node, instead of recursively looking up a child at any depth in the tree. A 2nd patch adds the ability to edit the FDT to remove a node and its subtree.