Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gobusybox #2735

Merged
merged 3 commits into from
Aug 7, 2023
Merged

Update Gobusybox #2735

merged 3 commits into from
Aug 7, 2023

Conversation

hugelgupf
Copy link
Member

@hugelgupf hugelgupf commented Aug 6, 2023

  • Use new golang.Default API
  • Always pass golang.Environ as a pointer
  • Use Environ.Lookup API to ensure build tags are passed even in binary build mode.

Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
@hugelgupf hugelgupf added the automerge Applying this label auto-merges the PR when ready label Aug 6, 2023
@codecov
Copy link

codecov bot commented Aug 6, 2023

Codecov Report

Patch coverage: 75.00% and project coverage change: +0.15% 🎉

Comparison is base (8031498) 75.38% compared to head (4afdd23) 75.53%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2735      +/-   ##
==========================================
+ Coverage   75.38%   75.53%   +0.15%     
==========================================
  Files         416      416              
  Lines       42380    42373       -7     
==========================================
+ Hits        31949    32008      +59     
+ Misses      10431    10365      -66     
Files Changed Coverage Δ
pkg/vmtest/integration.go 66.03% <0.00%> (+1.22%) ⬆️
pkg/uroot/builder/gbb.go 52.63% <50.00%> (-0.15%) ⬇️
pkg/uroot/builder/binary.go 83.33% <75.00%> (-4.17%) ⬇️
pkg/uroot/uroot.go 63.63% <100.00%> (ø)
pkg/vmtest/gotest.go 78.22% <100.00%> (-0.35%) ⬇️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Chris Koch <chrisko@google.com>
@orangecms orangecms merged commit f87ad7c into u-root:main Aug 7, 2023
23 of 24 checks passed
@hugelgupf hugelgupf deleted the updategbb branch August 7, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Applying this label auto-merges the PR when ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants