Fix /etc/ lossage in CreateRootfs #2746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 22, 2023
Codecov ReportPatch has no changes to coverable lines.
📢 Thoughts on this report? Let us know!. |
rminnich
reviewed
Aug 24, 2023
rminnich
added
the
Awaiting author
rjkroege
force-pushed
the
etc-lossage
branch
2 times, most recently
from
2dd120f
to
b9ec913
Compare
|
Rebased and hopefully fixed the issues. |
With this PR, CreateRootfs() in root_linux.go uses the NoFollowSymlinks option to correctly handle broken symlinks found in /etc when setting up the filesystems. Signed-off-by: Robert Kroeger <rjkroege@liqui.org>
|
oops. Now fixed. I apparently should automate this "signed off" thing. |
|
@rminnich Can you take another look. Also: the failing |
|
it certainly looks fine, I wonder if your fix found a broken test? |
|
@rminnich with your merge, all the tests pass except the in-the-noise change to coverage. LGTM maybe or should I go write some tests? 😊 |
rminnich
approved these changes
Sep 7, 2023
rminnich
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR,
CreateRootfs()inroot_linux.gouses theNoFollowSymlinksoption to correctly handle broken symlinks found in/etcwhen setting up the filesystems.\n