Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmds/core/mkdir: fix empty mode test if umask is not 022 #2760

Merged
merged 1 commit into from
Sep 11, 2023
Merged

cmds/core/mkdir: fix empty mode test if umask is not 022 #2760

merged 1 commit into from
Sep 11, 2023

Conversation

binjip978
Copy link
Contributor

No description provided.

@binjip978
cmds/core/mkdir: fix non mode test if umask is not 022
3354fd2 
Signed-off-by: Siarhiej Siemianczuk <pdp.eleven11@gmail.com>
@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

@binjip978
Copy link
Contributor Author

binjip978 commented Sep 9, 2023 •
edited
Loading

right now:

umask 002
go test

--- FAIL: TestMkdir (0.00s)
--- FAIL: TestMkdir/Default_createtion_mode (0.00s)
mkdir_test.go:147: Mode = 'drwxrwxr-x', want: 'drwxr-xr-x'

@binjip978 binjip978 added the Awaiting reviewer Waiting for a reviewer. label Sep 9, 2023
@rminnich rminnich merged commit 78e4ab3 into u-root:main Sep 11, 2023
24 checks passed
@binjip978 binjip978 deleted the mkdir-umask branch November 15, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rminnich rminnich rminnich approved these changes

Assignees
No one assigned
Labels
Awaiting reviewer Waiting for a reviewer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@binjip978 @rminnich