fbptcat: dump raw contents of FBPT table

[princegeutler]

fbptcat: dump raw contents of FBPT table
FBPT = Firmware Basic Performance Boot Table

• fbptcat is a shell command for printing the raw contents of
  Firmware Basic Performance Boot Table (FBPT) within ACPI FPDT

• New FPDT package created to contain functions concerning
  all tables and structures within ACPI FPDT

• New FPBT package created to contain functions concerning
  the FBPT Table found within ACPI FPDT

Signed-off-by: Prince Geutler geutlerprince@gmail.com

[rminnich]

This looks really useful, thanks!

Besides my very small nit, we're going to need tests.

But this is a super useful tool and I hope you are ok with writing them.

[rminnich]

if would really be nice to have this, can you tidy it up and we'll try again?

[princegeutler]

if would really be nice to have this, can you tidy it up and we'll try again?

Hi, yes thank you for the ping.

[princegeutler]

Hi,

I have a few questions:

• I am unsure how to run the test-suite locally. Is there an easy way to achieve this?

• I am having a bunch of commits in this pull request because I keep having to merge changes within u-root to my 'development' branch to make a new commit or amend my commits. Is this an issue? If so is there a more elegant way of modifying my pull request.

Thank you.

[codecov]

Codecov Report

Attention: 111 lines in your changes are missing coverage. Please review.

Files	Coverage Δ
pkg/acpi/fpdt/fpdt.go	26.66% <26.66%> (ø)
pkg/acpi/fpdt/fbpt/fbpt.go	0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

[princegeutler]

Codecov Report

Attention: 111 lines in your changes are missing coverage. Please review.

Files Coverage Δ
pkg/acpi/fpdt/fpdt.go 26.66% <26.66%> (ø)
pkg/acpi/fbpt/fbpt.go 0.00% <0.00%> (ø)
... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

Most of the code that I wrote in pkg/fpdt and pkg/fbpt parses the tables' contents which I can not verify since content can vary. I wrote a test to check the fpdt tables integrity by calculating the checksum (the fpbt table resides inside the fpdt table so its included in the checksum calculation). Are other tests/more code coverage needed?

EDIT : Just read integration test section of u-root, currently still working on tests.

[rminnich]

Well, you do need to add a DCO via git commit -s --amend for each commit

[iangoegebuer]

We have been chatting about how best to get more coverage.

At least for fbpt.go you may be able to do something similar to smbios_test.go and mock the memory ready functions. Every call to Seek and ReadFull go to a function which ultimately calls mem.Seek|ReadFull. Then you can override those functions for the test.

I'm worried refactoring to use memio might be slower due to the number of sequential reads you need to do here and the number of times memio would have to open, seek, read, close.

u-root/pkg/smbios/smbios_test.go

Lines 56 to 70 in 19031e1

	func TestSMBIOSBaseNotFound(t *testing.T) {
	systabPath = "testdata/systab_NOT_FOUND"
	defer func(old func(base int64, uintn memio.UintN) error) { memioRead = old }(memioRead)
	memioRead = func(base int64, uintn memio.UintN) error {
	return nil
	}
	_, _, err := SMBIOSBase()
	want := "could not find _SM_ or _SM3_ via /dev/mem from 0x000f0000 to 0x00100000"
	if err.Error() != want {
	t.Errorf("SMBIOSBase(): '%v', want %s", err, want)
	}
	}