Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmds/core/mv: remove globals flags #2767

Merged
merged 3 commits into from
Sep 26, 2023
Merged

cmds/core/mv: remove globals flags #2767

merged 3 commits into from
Sep 26, 2023

Conversation

binjip978
Copy link
Contributor

add test helper, remove dependency on test ordering

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage is 88.88% of modified lines.

Files Changed Coverage
cmds/core/mv/mv.go 88.88%

📢 Thoughts on this report? Let us know!.

@binjip978 binjip978 added the Awaiting reviewer Waiting for a reviewer. label Sep 19, 2023
Copy link
Member

@rminnich rminnich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a very nice improvement, could you see what you think of my little question?

cmds/core/mv/mv.go Outdated Show resolved Hide resolved
add test helper, remove dependency on test ordering

Signed-off-by: Siarhiej Siemianczuk <pdp.eleven11@gmail.com>
Signed-off-by: Siarhiej Siemianczuk <pdp.eleven11@gmail.com>
Copy link
Member

@rminnich rminnich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just 2 more little things, wdyt?

cmds/core/mv/mv.go Show resolved Hide resolved
cmds/core/mv/mv.go Outdated Show resolved Hide resolved
Signed-off-by: Siarhiej Siemianczuk <pdp.eleven11@gmail.com>
@rminnich rminnich added Awaiting author Waiting for new changes or feedback for author. and removed Awaiting reviewer Waiting for a reviewer. labels Sep 25, 2023
@binjip978 binjip978 merged commit 93dba23 into u-root:main Sep 26, 2023
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting author Waiting for new changes or feedback for author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants