Revamp ldd API

[hugelgupf]

New:

• ldd.List(paths ..string) -> lists dependency files (interps and dynamic libraries), as named in the given binary.
• ldd.FList(paths ...string) -> like List, but also lists all files pointed to through symlinks in the dependency files.

Neither of them return the original file name in paths anymore.

Removing:

• ldd.List (equivalent is FList, but FList does not list the original file name anymore)
• ldd.Ldd (there is nothing returning FileInfo anymore, because nothing was using it)

[codecov]

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Files	Coverage Δ
cmds/exp/pox/pox.go	55.03% <50.00%> (-10.98%)	⬇️
pkg/uroot/uroot.go	64.36% <0.00%> (+0.73%)	⬆️
pkg/ldd/ldd_unix.go	56.00% <34.88%> (-22.65%)	⬇️

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!

[rminnich]

it all looks fine but was there some driving reason or is this part of making things better.

Also I did stumble on this today:
r.minnich@2840nrd-rminnic tamago-example % otool -L /bin/date
/bin/date:
/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1336.0.0)

This is on osx. I wonder if we should use it when runtime.GOOS=darwin and our target is darwin?

[rminnich]

Is the behaviour of the lddfiles command still the same? Printing the file name was useful in scripts.

[hugelgupf]

Is the behaviour of the lddfiles command still the same? Printing the file name was useful in scripts.

I can add that back.

it all looks fine but was there some driving reason or is this part of making things better.

Yes, I couldn't get a list of just the un-followed symlink files out of the current API for warptools/ldshim#2

[hugelgupf]

PTAL

[rminnich]

if you can add it back, that would be nice. A common usage pattern is something like
lddfiles /bin/this /bin/that | cpio -o
and it's critical that /bin/that and /bin/that be included. That should probably be a test ...

[hugelgupf]

I already added it back

…

On Sun, Nov 5, 2023 at 22:17 ron minnich ***@***.***> wrote: if you can add it back, that would be nice. A common usage pattern is something like lddfiles /bin/this /bin/that | cpio -o and it's critical that /bin/that and /bin/that be included. That should probably be a test ... — Reply to this email directly, view it on GitHub <#2802 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAPG3EXNWBHWFO6BSVFZLNDYDBXHZAVCNFSM6AAAAAA66PRHGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJUGE2TIMBVHA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[hugelgupf]

Ping?