dhclient: ensure DHCPv6 address is routable if using non-multicast address #2845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dress Signed-off-by: Chris Koch <chrisko@google.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2845 +/- ##
==========================================
- Coverage 75.89% 75.71% -0.19%
==========================================
Files 423 423
Lines 42744 42769 +25
==========================================
- Hits 32442 32381 -61
- Misses 10302 10388 +86
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rminnich
approved these changes
Jan 11, 2024
10000TB
reviewed
Jan 11, 2024
| case <-ctx.Done(): | ||
| return nil, errors.New("timeout after waiting for a non-tentative IPv6 address") | ||
| } | ||
| } | ||
|
|
||
| // If user specified a non-multicast address, make sure it's routable before we start. | ||
| if c.V6ServerAddr != nil { |
There was a problem hiding this comment.
BTW, what are the practical cases where users are specifying this these days ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This de-flakes some Google-internal netboot testing which uses manually configured unicast IPv6 addresses.