flash/op: add String() and Bytes() for OpCode #2847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
|
just as one example, many compilers can generate very efficient code given a switch. It pays to give the compiler the option. But, given a map, the compiler has little choice but to do what you say. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2847 +/- ##
==========================================
+ Coverage 75.71% 75.72% +0.01%
==========================================
Files 423 424 +1
Lines 42769 42801 +32
==========================================
+ Hits 32382 32413 +31
- Misses 10387 10388 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
binjip978
approved these changes
Jan 11, 2024
rjoleary
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided not to use a map.
Using a switch lets the compiler optimize at it sees fit, where a map wires in a decision as to best implementation, a map sitting around we almost never need, and so on. I'm sensitive to this in a world of little devices.