Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capitalize log statements #2866

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Capitalize log statements #2866

merged 2 commits into from
Jan 24, 2024

Conversation

hugelgupf
Copy link
Member

No description provided.

Signed-off-by: Chris Koch <chrisko@google.com>
@hugelgupf hugelgupf marked this pull request as ready for review January 23, 2024 20:35
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (3d52f7b) 75.84% compared to head (60536b2) 75.70%.

Files Patch % Lines
pkg/sh/run.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2866      +/-   ##
==========================================
- Coverage   75.84%   75.70%   -0.15%     
==========================================
  Files         425      425              
  Lines       42832    42832              
==========================================
- Hits        32485    32424      -61     
- Misses      10347    10408      +61     
Flag Coverage Δ
.-amd64 67.87% <ø> (ø)
cmds/...-amd64 71.47% <ø> (+0.04%) ⬆️
integration/generic-tests/...-amd64 0.00% <ø> (ø)
integration/generic-tests/...-arm 0.00% <ø> (ø)
integration/generic-tests/...-arm64 0.00% <ø> (ø)
integration/gotests/...-amd64 73.98% <0.00%> (-0.20%) ⬇️
integration/gotests/...-arm 75.20% <0.00%> (-0.01%) ⬇️
integration/gotests/...-arm64 74.93% <0.00%> (+<0.01%) ⬆️
pkg/...-amd64 76.14% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hugelgupf hugelgupf merged commit d16c117 into u-root:main Jan 24, 2024
8 of 12 checks passed
@hugelgupf hugelgupf deleted the logs branch January 24, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants