Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce memory usage of amd64 userspace kexec #2888

Merged
merged 3 commits into from
Feb 3, 2024

Conversation

hugelgupf
Copy link
Member

@hugelgupf hugelgupf commented Feb 1, 2024

No unit tests here yet. Still covered by the integration test.

@hugelgupf hugelgupf marked this pull request as ready for review February 1, 2024 22:50
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ce5d5f5) 77.44% compared to head (41b0c51) 77.43%.

Files Patch % Lines
pkg/boot/linux/load_linux_amd64.go 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2888      +/-   ##
==========================================
- Coverage   77.44%   77.43%   -0.01%     
==========================================
  Files         430      430              
  Lines       43064    43067       +3     
==========================================
+ Hits        33349    33350       +1     
- Misses       9715     9717       +2     
Flag Coverage Δ
.-amd64 67.87% <ø> (ø)
cmds/...-amd64 71.40% <ø> (ø)
integration/generic-tests/...-amd64 17.84% <83.33%> (+0.20%) ⬆️
integration/generic-tests/...-arm 0.00% <ø> (ø)
integration/generic-tests/...-arm64 21.60% <ø> (ø)
integration/gotests/...-amd64 74.21% <0.00%> (-0.01%) ⬇️
integration/gotests/...-arm 75.53% <ø> (-0.01%) ⬇️
integration/gotests/...-arm64 75.50% <ø> (+0.07%) ⬆️
pkg/...-amd64 76.46% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hugelgupf hugelgupf enabled auto-merge (rebase) February 1, 2024 23:01
If the initramfs is already in memory at this point (e.g. in tmpfs), use
mmap to forego a second copy.

Signed-off-by: Chris Koch <chrisko@google.com>
…an 0x90000

Signed-off-by: Chris Koch <chrisko@google.com>
@hugelgupf hugelgupf closed this Feb 1, 2024
auto-merge was automatically disabled February 1, 2024 23:34

Pull request was closed

@hugelgupf hugelgupf reopened this Feb 1, 2024
@hugelgupf hugelgupf enabled auto-merge (rebase) February 1, 2024 23:46
@hugelgupf hugelgupf requested a review from a team February 2, 2024 23:52
@hugelgupf hugelgupf merged commit d257b72 into u-root:main Feb 3, 2024
26 checks passed
@hugelgupf hugelgupf deleted the kexec-amd64 branch February 3, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants