Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An update to vmtest #2918

Merged
merged 14 commits into from
Feb 17, 2024
Merged

An update to vmtest #2918

merged 14 commits into from
Feb 17, 2024

Conversation

hugelgupf
Copy link
Member

@hugelgupf hugelgupf commented Feb 16, 2024

vmtest has gotten some API overhauls. Sorry for the churn. Trying to improve things :)

One functional difference is that virtio-rng is not included by default anymore. That'll allow us to test dhclient behavior when rng is not there / broken (no hangs!)

We're also starting to use https://github.com/u-root/mkuimage here instead of pkg/u-root.

Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (59b256e) 78.22% compared to head (67b2ddb) 77.97%.

Files Patch % Lines
vendor/github.com/hugelgupf/vmtest/guest/skip.go 0.00% 3 Missing ⚠️
...or/github.com/hugelgupf/vmtest/guest/kcov_linux.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2918      +/-   ##
==========================================
- Coverage   78.22%   77.97%   -0.25%     
==========================================
  Files         421      430       +9     
  Lines       42893    43153     +260     
==========================================
+ Hits        33552    33649      +97     
- Misses       9341     9504     +163     
Flag Coverage Δ
.-amd64 67.87% <ø> (ø)
cmds/...-amd64 70.48% <55.55%> (-0.93%) ⬇️
integration/generic-tests/...-amd64 20.41% <42.85%> (-0.11%) ⬇️
integration/generic-tests/...-arm 11.74% <42.85%> (+0.04%) ⬆️
integration/generic-tests/...-arm64 23.74% <42.85%> (-0.24%) ⬇️
integration/gotests/...-amd64 74.47% <55.55%> (-0.22%) ⬇️
integration/gotests/...-arm 75.88% <55.55%> (-0.24%) ⬇️
integration/gotests/...-arm64 75.70% <55.55%> (-0.24%) ⬇️
pkg/...-amd64 76.36% <55.55%> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hugelgupf
Copy link
Member Author

Ok, interestingly we are now also collecting integration test coverage from some small part of vmtest in vendor, but I'll fix that later...

@hugelgupf hugelgupf added the Awaiting reviewer Waiting for a reviewer. label Feb 16, 2024
@hugelgupf hugelgupf merged commit f17235f into u-root:main Feb 17, 2024
22 of 24 checks passed
@hugelgupf hugelgupf deleted the vmtest branch February 17, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting reviewer Waiting for a reviewer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants